Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] signal-desktop: 1.31.0 -> 1.32.0 (backport) #81818

Merged
merged 1 commit into from Mar 6, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 5, 2020

(cherry picked from commit 05e6cc4)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit 05e6cc4)
@primeos
Copy link
Member Author

primeos commented Mar 5, 2020

@GrahamcOfBorg test signal-desktop

Update: Unrelated OOM error (log) - I'll try it again a bit later.

@primeos
Copy link
Member Author

primeos commented Mar 5, 2020

@GrahamcOfBorg test signal-desktop

@primeos
Copy link
Member Author

primeos commented Mar 6, 2020

nixosTests.signal-desktop also OOM'ed locally or timed out (something else is probably broken), but running Signal-Desktop in a test VM seemed fine.

@primeos primeos merged commit 71c6a1c into NixOS:release-19.09 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant