Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] brave 1.4.95 to 1.4.96 #81793

Merged
merged 1 commit into from Mar 5, 2020
Merged

[20.03] brave 1.4.95 to 1.4.96 #81793

merged 1 commit into from Mar 5, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 5, 2020 •
edited

Update brave from the version 1.4.95 to 1.4.96.

(cherry picked from commit 3f6d356)
Reason: Keep the browser to the latest stable version

Backport the PR #81788

Motivation for this change

The browser should be kept up-to-date

Things done

Update the version and update the checksum accordingly

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
brave: 1.4.95 -> 1.4.96
093092a 
Update brave from the version 1.4.95 to 1.4.96.

(cherry picked from commit 3f6d356)
Reason: Keep the browser to the latest stable version
@ofborg ofborg bot requested review from uskudnik and rht March 5, 2020 03:00
@rht
Copy link
Member

rht commented Mar 5, 2020

LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pr-approved-browser-brave-backport/6122/1

@worldofpeace worldofpeace changed the title [20.03]brave 1.4.95 to 1.4.96 [20.03] brave 1.4.95 to 1.4.96 Mar 5, 2020
@worldofpeace worldofpeace merged commit c4db4e5 into NixOS:release-20.03 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @rht @nixos-discourse @worldofpeace