Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19 09] brave 1.4.95 to 1.5.112 #81789

Merged
merged 2 commits into from Mar 19, 2020
Merged

[19 09] brave 1.4.95 to 1.5.112 #81789

merged 2 commits into from Mar 19, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 5, 2020 •
edited

Update brave from the version 1.4.95 to 1.4.96.

(cherry picked from commit 3f6d356)
Reason: Keep the browser to the latest stable version

Backport the PR #81788 and #82894

Motivation for this change

Keep the browser up-to-date for everyone

Things done

Update the version and the checksum

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
brave: 1.4.95 -> 1.4.96
edbe456 
Update brave from the version 1.4.95 to 1.4.96.

(cherry picked from commit 3f6d356)
Reason: Keep the browser to the latest stable version
@ofborg ofborg bot requested review from rht and uskudnik March 5, 2020 02:36
rht
rht approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@rht rht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pr-approved-browser-brave-backport/6122/1

@worldofpeace worldofpeace changed the base branch from nixos-19.09 to release-19.09 March 5, 2020 19:40
@ofborg ofborg bot requested a review from rht March 5, 2020 19:49
@JeffLabonte
brave: 1.4.96 -> 1.5.112
0e01f4f 
keep brave up-to-date

(cherry picked from commit 418e3e4)
Reason: Browsers should be kept up-to-date for security reasons
@JeffLabonte JeffLabonte changed the title [19 09] brave 1.4.95 to 1.4.96 [19 09] brave 1.4.95 to 1.5.112 Mar 19, 2020
@grahamc grahamc merged commit 8963012 into NixOS:release-19.09 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uskudnik uskudnik Awaiting requested review from uskudnik

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @nixos-discourse @rht @grahamc