Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rakudo: 2020.02 -> 2020.02.1 #81821

Merged
merged 1 commit into from Mar 27, 2020
Merged

rakudo: 2020.02 -> 2020.02.1 #81821

merged 1 commit into from Mar 27, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 5, 2020

Updated rakudo and dependencies to 2020.02.01

dependencies:
moarvm: 2020.02 -> 2020.02.1
nqp: 2020.02 -> 2020.02.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
rakudo: 2020.02 -> 2020.02.1
0aa764d 
dependencies:
moarvm: 2020.02 -> 2020.02.1
nqp: 2020.02 -> 2020.02.1
@stigtsp stigtsp mentioned this pull request Mar 5, 2020
Closed
@ofborg ofborg bot requested review from vrthra and thoughtpolice March 5, 2020 12:10
jonringer
jonringer reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break this into 3 different PRs, one for each package bump

@stigtsp
Copy link
Member Author

stigtsp commented Mar 6, 2020 •
edited

please break this into 3 different PRs, one for each package bump

The versions of rakudo -> nqp -> moarvm are tighly linked, so individual PRs for each of them will likely fail to build. They should be bumped together.

@jonringer
Copy link
Contributor

it's more git bisect, it would be nice to trace what package bump corresponds to a potential regression

@jonringer
Copy link
Contributor

there's other reasons as well, the PR should just contain all 3 bumps

@alyssais
Copy link
Member

please break this into 3 different PRs

there's other reasons as well, the PR should just contain all 3 bumps

I assume you mean that they should break this into three commits, all in the same PR?

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

didn't see that they were all co-located at first

[8 built, 1 copied (0.3 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81821
4 package built:
moarvm nqp rakudo zef

@jonringer jonringer merged commit 62831e1 into NixOS:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@vrthra vrthra Awaiting requested review from vrthra

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @jonringer @alyssais