Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
My previous fix (now merged #80154) introduced a bug by removing
apply = lib.mapAttrs (name: text: pkgs.writeText "${name}" text);
causingshorewall.service
to be corrupted, becauseX-Restart-Triggers
is now set to a garbage value (the content of the files instead of their paths).The service was still starting but many warnings of wrong syntax were emitted in its logs.
Things done
Fix
Restart-Triggers
inshorewall
andshorewall6
services by revertingapply
and using.source
instead of.text
.For config files, the more correct
types.lines
is also used instead oftypes.str
.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)