Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow: 1.15.1 -> 1.15.2 #81772

Merged
merged 1 commit into from Mar 9, 2020
Merged

tensorflow: 1.15.1 -> 1.15.2 #81772

merged 1 commit into from Mar 9, 2020

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Mar 4, 2020

Motivation for this change

The 1.15.1 release of tensorflow was apparently revoked (I'm guessing due to the security issues therein) and there's only 1.15.2 now in this series. I've just made the obvious changes and verified it builds (both cpu and gpu) but haven't done any other extensive testing.

Happy to retarget this to another branch or withdraw in favor of a more complete update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar March 4, 2020 23:22
@mjlbach
Copy link
Contributor

mjlbach commented Mar 4, 2020

This LGTM, I should have bumped the version to 1.15.2 (instead of 1.15.1) when I did the last bump.

@lovesegfault
Copy link
Member

cc. @andir

@andir
Copy link
Member

andir commented Mar 9, 2020

Looks good. I am running a build of both flavors (cuda / no cuda) now.

@andir andir merged commit 6a662cb into NixOS:release-20.03 Mar 9, 2020
@andir
Copy link
Member

andir commented Mar 12, 2020

I just realized that this targeted 20.03, I'm working on a port to master so this is still in-sync.

@andir andir mentioned this pull request Mar 12, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dylex @mjlbach @lovesegfault @andir