Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube3d: correct k3s version tag #81777

Merged
merged 1 commit into from Mar 5, 2020
Merged

Conversation

ngerstle
Copy link
Contributor

@ngerstle ngerstle commented Mar 4, 2020

Motivation for this change

The version tag for k3s is incorrect, by one character. Testing of my previous change (#81428) was insufficient to pick this up (the binary file was executable, but critical functionality was untested).
Without this, k3d is unable to pull a version of k3s to run.
Testing this round included creating and deleting a cluster, and running through the first k3d example on deploying nginx and exposing it via an ingress service (https://github.com/rancher/k3d/blob/master/docs/examples.md).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit e2ec8dc into NixOS:master Mar 5, 2020
@ngerstle ngerstle deleted the fix-kube3d-1.6.0 branch March 7, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants