Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot-{web,desktop}: 1.5.10 -> 1.5.12 #81849

Merged
merged 2 commits into from Mar 5, 2020
Merged

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Mar 5, 2020

Motivation for this change

This updates riot-web and riot-desktop to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
gui starts fine

[7 built, 1 copied (171.8 MiB), 47.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81849
1 package built:
riot-desktop

@jonringer jonringer merged commit abc58dc into NixOS:master Mar 5, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 6, 2020

@jonringer as this is a patch release with bugfixes: any reason not to backport this (at least to 20.03)? :)

@jonringer
Copy link
Contributor

not really, I more or less am trying to get contributions that are ready to merge into nixpkgs.

@jonringer
Copy link
Contributor

I don't see a reason not to

@Ma27
Copy link
Member

Ma27 commented Mar 6, 2020

Fine, will do the backport then :)

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 6, 2020
@Ma27 Ma27 self-assigned this Mar 6, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 6, 2020

Backported as b780aef, 44d322f.

@pacien I found one problem though: it's not possible anymore to set default_hs_url and default_server_config at the same time (riot refuses to work in that case).
I stumbled upon this issue as I have a default_hs_url in my config which worked perfectly fine with riot-web 1.5.10. A workaround is to set default_server_config to null (it's only used to set matrix.org as default hs atm). Do you think it's a good idea to unset default_server_config from config.sample.json by default?

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 6, 2020
@pacien
Copy link
Contributor Author

pacien commented Mar 7, 2020

@pacien I found one problem though: it's not possible anymore to set default_hs_url and default_server_config at the same time (riot refuses to work in that case).
I stumbled upon this issue as I have a default_hs_url in my config which worked perfectly fine with riot-web 1.5.10. A workaround is to set default_server_config to null (it's only used to set matrix.org as default hs atm). Do you think it's a good idea to unset default_server_config from config.sample.json by default?

There's no default_hs_url config key in the example config file: https://github.com/vector-im/riot-web/blob/develop/config.sample.json.

@Ma27
Copy link
Member

Ma27 commented Mar 7, 2020

Yes, the issue occurs if I want to declare it in my config.

@pacien
Copy link
Contributor Author

pacien commented Mar 7, 2020

You should remove default_hs_url from your configuration because it's deprecated:

From https://github.com/vector-im/riot-web/blob/develop/docs/config.md:

Note: The URLs can also be individually specified as default_hs_url and default_is_url, however these are deprecated.

I don't think we should unset default_server_config because it's quite helpful for new users.

@Ma27
Copy link
Member

Ma27 commented Mar 7, 2020

I see, that's the detail I was missing :)
Then it's alright I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants