New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riot-{web,desktop}: 1.5.10 -> 1.5.12 #81849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
gui starts fine
[7 built, 1 copied (171.8 MiB), 47.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81849
1 package built:
riot-desktop
@jonringer as this is a patch release with bugfixes: any reason not to backport this (at least to 20.03)? :) |
not really, I more or less am trying to get contributions that are ready to merge into nixpkgs. |
I don't see a reason not to |
Fine, will do the backport then :) |
Backported as b780aef, 44d322f. @pacien I found one problem though: it's not possible anymore to set |
There's no |
Yes, the issue occurs if I want to declare it in my config. |
You should remove From https://github.com/vector-im/riot-web/blob/develop/docs/config.md:
I don't think we should unset |
I see, that's the detail I was missing :) |
Motivation for this change
This updates riot-web and riot-desktop to the latest release.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)