Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwsafe: 1.08.2 -> 1.09.0 #81823

Merged
merged 1 commit into from Mar 18, 2020
Merged

pwsafe: 1.08.2 -> 1.09.0 #81823

merged 1 commit into from Mar 18, 2020

Conversation

chrbauer
Copy link
Contributor

@chrbauer chrbauer commented Mar 5, 2020

fixes the broken build
there is a problem with wxGTK 3.1.2
maybe related to
https://github.com/pwsafe/pwsafe/blob/master/src/ui/wxWidgets/TreeCtrl.cpp
line 107
So I use wxGTK30

file is a new depedency

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fixes the broken build
there is a problem with wxGTK 3.1.2
maybe related to
https://github.com/pwsafe/pwsafe/blob/master/src/ui/wxWidgets/TreeCtrl.cpp
line 107
So I use wxGTK30

file is a new depedency
@chrbauer
Copy link
Contributor Author

I'm using this version for some time on nixos 20.03. The good thing is: the build is working.
But there are some issues:
DnD in Gnome crashes the gnome session and copy password to clipboard has a problem. :-(

@chrbauer
Copy link
Contributor Author

DnD problem doesn't occur with KDE

@mrkkrp
Copy link
Member

mrkkrp commented Mar 17, 2020

Is there something that prevents this from being merged?

@chrbauer
Copy link
Contributor Author

the current status is: it builds again and you have access to your passwords. but there are some bugs in this app. i don't have the time to investigate.

@chrbauer
Copy link
Contributor Author

i guess it should be merged to 20.03 as well

@Mic92 Mic92 changed the title pwsafe -> 1.9.0 pwsafe: 1.08.2 -> 1.09.0 Mar 18, 2020
@Mic92 Mic92 merged commit 50cabb2 into NixOS:master Mar 18, 2020
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2020

backport: 6bbdce2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants