Deploy to Netlify #330
Merged
Deploy to Netlify #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can get a NixOS homepage in a container by running $ nixos-container create homepage --flake nixos-homepage
Flake input changes: * Added 'hydra': 'github:NixOS/hydra/be8eb9d00d6a3fcac520bc7dfd5740c0b3ade746' * Added 'hydra/nix': 'github:NixOS/nix/4ad5826a182f8eeb4cbc61e27d2128b08050b0d4' * Added 'hydra/nix/nixpkgs': 'github:edolstra/nixpkgs/43e283790fbe330b723ac44b584824cf6d85c1ee' * Added 'hydra/nixpkgs': 'github:edolstra/nixpkgs/d959778e0934c4c93896d509a65de798909c7cdd' * Added 'nix': 'github:NixOS/nix/4a4521f46253e87a06af9333381c050e983b3c2f' * Added 'nix/nixpkgs': 'github:edolstra/nixpkgs/43e283790fbe330b723ac44b584824cf6d85c1ee' * Added 'nixpkgsStable': 'github:edolstra/nixpkgs/581caef4f5d58573c96ab6e9dbf1160209372029' * Added 'nixpkgsUnstable': 'github:NixOS/nixpkgs/82cbc6af3cbb77a07e1725554119e0fb032d7cf6'
zimbatm
reviewed
Mar 5, 2020
| with: | ||
| publish-dir: './build' | ||
| production-branch: 'master' | ||
| github-token: ${{ secrets.GH_TOKEN }} |
There was a problem hiding this comment.
there is a default token you can use that is able to post comments on the pull request:
Suggested change
| github-token: ${{ secrets.GH_TOKEN }} | |
| github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I tried to use that and it didn't work ... it got stuck at fetching the token i think.
There was a problem hiding this comment.
Was the branch pushed on a forked repo or the nixos-homepage repo?
garbas
added a commit
to garbas/nixos-org-configurations
that referenced
this pull request
Mar 5, 2020
zimbatm
pushed a commit
to NixOS/infra
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I already went ahead and configured secrets needed for this to work in NixOS/nixos-homepage repository. Secrets that I configures are:
For now I generated github and netlify token from my own account. I wonder if we should create a separate accounts only for this (eg. nixos-homepage-bot on github and nixos-homepage-webmaster on netlify).
You can find preview links in the PR history.
/cc @samueldr @edolstra