Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomatrix: init at 101.0.0 #81799

Merged
merged 1 commit into from Mar 9, 2020
Merged

gomatrix: init at 101.0.0 #81799

merged 1 commit into from Mar 9, 2020

Conversation

skykanin
Copy link
Contributor

@skykanin skykanin commented Mar 5, 2020 •
edited

Motivation for this change

This PR introduces gomatrix, a tool to print a matrix-like screensaver in your terminal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 5, 2020 05:01
Valodim
Valodim approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, binary works as expected

pkgs/applications/misc/gomatrix/default.nix Outdated Show resolved Hide resolved
@skykanin skykanin requested a review from Valodim March 7, 2020 07:21
doronbehar
doronbehar approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very useful package ;).

@marsam marsam merged commit f32e17d into NixOS:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim approved these changes

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skykanin @Valodim @doronbehar @marsam