Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r8125: init at 9.003.02 #81835

Merged
merged 2 commits into from Mar 10, 2020
Merged

r8125: init at 9.003.02 #81835

merged 2 commits into from Mar 10, 2020

Conversation

notpeelz
Copy link

@notpeelz notpeelz commented Mar 5, 2020

Motivation for this change

My motherboard has 2.5G Ethernet port that requires a Realtek driver to work.

Note: I had to mirror the Realtek files through a personal git repo because Realtek doesn't allow direct downloads.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/os-specific/linux/r8125/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/os-specific/linux/r8125/default.nix Show resolved Hide resolved
@notpeelz notpeelz force-pushed the kmod-r8125 branch 2 times, most recently from 02c923d to 037fb1e Compare March 6, 2020 00:03
@notpeelz notpeelz force-pushed the kmod-r8125 branch 2 times, most recently from 2b445ae to d0584ca Compare March 6, 2020 06:19
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the spirit of rfc 45, otherwise LGTM

pkgs/os-specific/linux/r8125/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[13 built (1 failed), 18 copied (1611.9 MiB), 742.1 MiB DL]
error: build of '/nix/store/41vkarsmp05kshcsqgcxv6k83qv02pp7-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81835
2 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_latest.r8125

1 package failed to build:
linuxPackages_testing_hardened.r8125

13 package built:
linuxPackages-libre.r8125 linuxPackages.r8125 linuxPackages_4_14.r8125 linuxPackages_4_19.r8125 linuxPackages_4_4.r8125 linuxPackages_4_9.r8125 linuxPackages_5_5.r8125 linuxPackages_hardened.r8125 linuxPackages_latest-libre.r8125 linuxPackages_latest_hardened.r8125 linuxPackages_latest_xen_dom0.r8125 linuxPackages_testing_bcachefs.r8125 linuxPackages_xen_dom0.r8125

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[14 built (1 failed), 30 copied (2381.9 MiB), 1097.5 MiB DL]
error: build of '/nix/store/9kaiqm1p6s3ciw7ahbvak8wbaqyn4841-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81835
2 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_latest.r8125

1 package failed to build:
linuxPackages_testing_hardened.r8125

13 package built:
linuxPackages-libre.r8125 linuxPackages.r8125 linuxPackages_4_14.r8125 linuxPackages_4_19.r8125 linuxPackages_4_4.r8125 linuxPackages_4_9.r8125 linuxPackages_5_5.r8125 linuxPackages_hardened.r8125 linuxPackages_latest-libre.r8125 linuxPackages_latest_hardened.r8125 linuxPackages_latest_xen_dom0.r8125 linuxPackages_testing_bcachefs.r8125 linuxPackages_xen_dom0.r8125

@jonringer
Copy link
Contributor

@GrahamcOfBorg build linuxPackages_4_19.r8125 linuxPackages_5_4.r8125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants