Update lvgui for better pointer support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, there is no trivial way to dinstinguish a trackpad from a touchscreen.
This adds the necessary support to better handle other pointing-type inputs. * Cursor for non-touch devices * Handle abs min/max * Handle touchpads With this, a tablet-type input, like used by QEMU, now works.
samueldr
force-pushed
the
feature/boot-gui/inputs-fixes
branch
from
d409013
to
022f3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary support to better handle other pointing-type
inputs.
With this, a tablet-type input, like used by QEMU, now works.
This is important for non-touch uses. It seems antithetical to "Mobile" NixOS, but it's not. The whole boot chain should be dogfood-able on any device NixOS runs. Not all of them have touchscreens.
Though, with that said, an improvement could be made with the cursor. The main one would be to use a circle "touch zone" cursor. The way LVGL handles cursors it's not possible, as it assumes[0, 0]on the object given as a cursor is the pointy bit of the pointer. A non LVGL-native handling of the cursor will be needed. This would, in turn, gives us the benefit of being able to guesstimate touch inputs from non-touch, and hide the cursor likeunclutterdoes, hiding quicker when we're sure it's a touch.With the new way I handle touchpads/mice, we can drop that requirement, at least for now. Touch-only devices will not see a cursor, and if you have touch+mice the cursor will not jump on touch.