Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-grid] Expected height in grid-percentage-rows-indefinite-height-002.html does not seem to consider the set border #21197

Closed
karstenw-ro opened this issue Jan 15, 2020 · 2 comments
Closed

[css-grid] Expected height in grid-percentage-rows-indefinite-height-002.html does not seem to consider the set border #21197

karstenw-ro opened this issue Jan 15, 2020 · 2 comments
Labels
css-grid type:bug

Comments

@karstenw-ro
Copy link
Contributor

In this test, the expected height of the grid container of second test case does not seem to consider it's border.

While it's first and third row should have a height of 25px each, the height of the second element should be 10px ((25px + 25px)*0.2). This would already reach the total expected height of the container (60px). However the border of the element adds an additional 10px.
@gsnedders
Copy link
Member

cc/ @mrego

@mrego
Copy link
Member

mrego commented Jan 21, 2020

No, it's fine. The height is 25px + 25px plus the border 10px, so it's 60px.
Then the 20% is resolved later, and the 2nd row has 10px size (20%*50px).

All this is explained at https://blogs.igalia.com/mrego/2018/08/10/changes-on-css-grid-layout-in-percentages-and-indefinite-height/.
Also this is failing in Firefox as the following bug is not solved yet: https://bugzilla.mozilla.org/show_bug.cgi?id=1481876

@mrego mrego closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-grid type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrego @gsnedders @karstenw-ro