Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscenegraph: 3.6.4 -> 3.6.5 #77799

Merged
merged 1 commit into from Feb 25, 2021
Merged

openscenegraph: 3.6.4 -> 3.6.5 #77799

merged 1 commit into from Feb 25, 2021

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 16, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c January 16, 2020 02:18
@aanderse aanderse mentioned this pull request Jan 22, 2020
Merged
10 tasks
@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2020

~> nix-review pr 77799

3 package failed to build:
flightgear openmw-tes3mp simgear

@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2020

Looks like this PR might have to idle until flightgear and simgear are updated to work with openscenegraph 3.6.5 😞

@7c6f434c
Copy link
Member

7c6f434c commented Feb 4, 2020

Maybe just split an old version for them?

@aanderse aanderse mentioned this pull request Jun 29, 2020
Merged
10 tasks
@turion
Copy link
Contributor

turion commented Jun 30, 2020

@aanderse Can you rebase onto master? simgear was already updated once to #88773.

@wucke13 wucke13 mentioned this pull request Dec 14, 2020
Merged
10 tasks
@stale
Copy link

stale bot commented Dec 27, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 27, 2020
@tomberek
Copy link
Contributor

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 77799 run on x86_64-linux 1

1 package marked as broken and skipped:
  • openmodelica
1 package failed to build and are new build failure:
  • openmw-tes3mp: log was empty
3 packages built:
  • openmw
  • openscenegraph
  • simgear

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 24, 2021
@turion
Copy link
Contributor

turion commented Feb 24, 2021

1 package failed to build and are new build failure:

* openmw-tes3mp: log was empty

For me openmw-tes3mp fails on master already.

@aanderse
Copy link
Member Author

It looks like a url changed because flightgear is failing on stable right now. I'll have to fix this so stable works again, and then I can validate if this PR breaks flightgear or not...

For reference, running nix-shell -p flightgear on stable right now:

trying https://downloads.sourceforge.net/flightgear/release-
2020.1/FlightGear-2020.1.2-data.tar.bz2
  % Total    % Received % Xferd  Average Speed   Time    Tim
e     Time  Current
                                 Dload  Upload   Total   Spe
nt    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--
:-- --:--:--     0
100   381  100   381    0     0    915      0 --:--:-- --:--
:-- --:--:--   915
  0     0    0     0    0     0      0      0 --:--:-- --:--
:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download FlightGear_logo.png from any mirror
builder for '/nix/store/1v21afk3nyq0sdhr96ryzrxgdwv29760-Fli
ghtGear_logo.png.drv' failed with exit code 1
cannot build derivation '/nix/store/ag26w5rlv5n2srck69d03sc7
82hpz7l5-flightgear-2020.1.2.drv': 1 dependencies couldn't b
e built
error: build of '/nix/store/ag26w5rlv5n2srck69d03sc782hpz7l5
-flightgear-2020.1.2.drv' failed

@aanderse aanderse mentioned this pull request Feb 25, 2021
Merged
10 tasks
@aanderse aanderse marked this pull request as ready for review February 25, 2021 13:03
@aanderse
Copy link
Member Author

flightgear compiles and runs now. This PR is good to go 👍

@tomberek tomberek merged commit daf30a5 into NixOS:master Feb 25, 2021
@aanderse aanderse deleted the openscenegraph branch February 25, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @7c6f434c @turion @tomberek