Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support git send-email on Darwin #77817

Merged
merged 1 commit into from Jan 16, 2020
Merged

Support git send-email on Darwin #77817

merged 1 commit into from Jan 16, 2020

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Jan 16, 2020

Motivation for this change

This is useful when working on projects that use email-based workflow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS N/A
    • macOS
    • other Linux distributions N/A
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Jan 16, 2020
@alyssais
Copy link
Member

Please format your commit message according to CONTRIBUTING.md.

@GrahamcOfBorg build gitFull

@alyssais alyssais merged commit 3d6c99a into NixOS:master Jan 16, 2020
@alyssais
Copy link
Member

Did the commit message myself. :)

@hauleth hauleth deleted the enable-email-support-on-darwin branch February 27, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hauleth @alyssais