[css-grid] Fix grid-layout-properties.html WPT test #21203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
This is a follow-up of r728894. It affected the behavior of the WPT test grid-layout-properties.html, but I didn't notice it since it was marked as failing. Mozilla updated the test in https://bugzil.la/1599206, but they didn't cover some cases that were already failing for them since Firefox doesn't serialize shorthands. Also, a case that used to expect "150px 50px 50px" should have been changed to "150px" (removing the trailing implicit tracks), but Mozilla changed it to "50px" since it's what they get due to a Firefox bug. Here I'm fixing the test to expect the correct values, unmarking it as failing, and adding an -expected.txt for the cases that fail due to bug 511177. BUG=1024927 Change-Id: I7ff8d248a708af273cd89d438ffd2692783a5bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002579 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#732336}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002579
branch
from
9ff67cc
to
aec18fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of r728894. It affected the behavior of the WPT test
grid-layout-properties.html, but I didn't notice it since it was marked
as failing.
Mozilla updated the test in https://bugzil.la/1599206, but they didn't
cover some cases that were already failing for them since Firefox
doesn't serialize shorthands.
Also, a case that used to expect "150px 50px 50px" should have been
changed to "150px" (removing the trailing implicit tracks), but Mozilla
changed it to "50px" since it's what they get due to a Firefox bug.
Here I'm fixing the test to expect the correct values, unmarking it as
failing, and adding an -expected.txt for the cases that fail due to
bug 511177.
BUG=1024927
Change-Id: I7ff8d248a708af273cd89d438ffd2692783a5bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002579
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732336}