ElementTiming and LargestContentfulPaint: add more redirect tests #21173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 14, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2001070
branch
2 times, most recently
from
ecab542
to
bbc8dbd
Compare
This CL adds more tests for Timing-Allow-Origin checks in ElementTiming and LargestContentfulPaint with multiple redirects. Before, we had tests for: * Single cross-origin response with a TAO header (image-TAO.sub.html). * Multiple redirects, with '*' TAO header (multi-redirect-image.html). This CL renames the latter to be more descriptive and adds: * Same-origin redirect tests (should pass without TAO headers). * Multi-cross-origin redirect tests with various TAO header values. Bug: 1003943 Change-Id: Id44f0f18f143c8ca4ee3ca40c2383fa2ae22590c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001070 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#732589}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2001070
branch
from
bbc8dbd
to
cdf56db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds more tests for Timing-Allow-Origin checks in ElementTiming
and LargestContentfulPaint with multiple redirects. Before, we had tests
for:
This CL renames the latter to be more descriptive and adds:
Bug: 1003943
Change-Id: Id44f0f18f143c8ca4ee3ca40c2383fa2ae22590c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001070
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732589}