-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
httpie: 1.0.3 -> 2.0.0 #77722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpie: 1.0.3 -> 2.0.0 #77722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested !
All fine for me.
Thanks
Just done a quick reading of upstream changelog, it mentions:
Does it change our test phase? Maybe there is more or better testing available. |
I would guess it only affects people using the pypi package (like if we used fetchPypi instead of fetchFromGitHub). We currently got tests running from the But it seems we can remove the disabledTests.
|
It seems the problem is that httpie now use a virtual env (venv) which is not set up or it's missing docutils. Should we set up that env properly or patch it out? |
Does it work if you add docutils to |
No. I think it's because python's path is hardcoded: I added a patch to fix that but for some reason the test doesn't fail if I remove |
Thanks! |
Motivation for this change
update
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I only tested http-prompt quickly. A simple GET worked.
$ nix path-info -h -S /nix/store/zakzw9m8pcp1z2lf7i4lvk34naybx9na-httpie-1.0.3
/nix/store/zakzw9m8pcp1z2lf7i4lvk34naybx9na-httpie-1.0.3 115.8M
$ nix path-info -h -S /nix/store/jscqy7pkcqrj9zhy1rjshhsz7vhj99z2-httpie-2.0.0
/nix/store/jscqy7pkcqrj9zhy1rjshhsz7vhj99z2-httpie-2.0.0 115.9M