gnunet: 0.12.1 -> 0.12.2 #77785
Merged
gnunet: 0.12.1 -> 0.12.2 #77785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking — are you happy with the author name/email of the commit? Asking because it doesn’t seem to be associated with your GitHub account. |
|
Ah, thank you for mentioning it. |
|
Ah, thank you for mentioning it.
Still doesn't look right, I'm afraid. Notice how there's no avatar
shown next to the commits on GitHub? You'll also need to do
git commit --amend --reset-author to tell Git to change the metadata
in the Author field (as opposed to just the Committer field).
|
|
Aha! The Email in the commit needs to match a validated one in the profile. I guess that's smart for security reasons. Since I don't publish my sign-up emails, I didn't use that in the commit, but I could add that public emails to my profile and now there are pretty pictures in the commit. Thanks again! |
|
Aha! The Email in the commit needs to match a validated one in the
profile. I guess that's smart for security reasons. Since I don't
publish my sign-up emails, I didn't use that in the commit, but I
could add that public emails to my profile and now there are pretty
pictures in the commit. Thanks again!
The author metadata in the commit still doesn't look right, but the
committer does now. Did you use --reset-author?
|
|
ping @pstn. |
|
It took me a while but now it's also signed ^^ Also rebased on current master and rebuilt without issues. |
|
ping @jonringer for review before feature freeze. |
jonringer
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Quick bump for the minor release.
Things done
sandboxinnix.confon non-NixOS linux)nixpkgs-review pr 77785./result/bin/)nix path-info -Sbefore and after)