[FlexNG] Fix flex-basis for aspect ratio items. #21178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986054
branch
4 times, most recently
from
3b91737
to
9486ff7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986054
branch
from
9486ff7
to
1a3bc46
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986054
branch
3 times, most recently
from
b84c3fc
to
759269a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986054
branch
3 times, most recently
from
7421522
to
3bd1e46
Compare
This refactors flex base size calculation to more explicitly match the parts of https://drafts.csswg.org/css-flexbox/#algo-main-item . As a result it is pretty verbose. Bug: 845235 Change-Id: I1a49c7f153b8e0779b1d1eaa1206bd5056e9da2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986054 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#740525}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986054
branch
from
3bd1e46
to
1afd32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors flex base size calculation to more explicitly match the
parts of https://drafts.csswg.org/css-flexbox/#algo-main-item . As a
result it is pretty verbose.
Bug: 845235
Change-Id: I1a49c7f153b8e0779b1d1eaa1206bd5056e9da2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986054
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740525}