Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test entry and incumbent settings object for promise jobs #21206

Merged
merged 8 commits into from Feb 12, 2020

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 15, 2020

Follows whatwg/html#5212 which specifies entry, and throws in incumbent tests for good measure while we're here.

Chrome and Firefox both seem to pass these, which is somewhat surprising.

@domenic domenic changed the title Test entry settings object for promise jobs Test entry and incumbent settings object for promise jobs Jan 15, 2020

const thenable = {
// No t.step_func because that could change the realms
then(f) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere around here should we have a test where the then function of the thenable is effectively a scripted function from the incumbent global (perhaps runWindowPostMessageVeryIndirectly bound to some args)? Maybe it doesn't matter too much....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I quite understand what this adds over the (2) suggested above (where the then function is from a different realm). Is using the incumbent global in particular important?

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the domenic/entry-for-promise-jobs branch January 24, 2020 18:06
@gsnedders gsnedders restored the domenic/entry-for-promise-jobs branch January 24, 2020 18:50
@Hexcles Hexcles reopened this Jan 24, 2020
Ms2ger added a commit that referenced this pull request Jun 19, 2020
Ms2ger added a commit that referenced this pull request Jun 19, 2020
Ms2ger added a commit that referenced this pull request Jun 23, 2020
Ms2ger added a commit that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants