fluidasserts: init at 20.1.22554 #77787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jan 16, 2020
pkgs/development/python-modules/fluidasserts/overlays/mixpanel.nix
Outdated
Show resolved
Hide resolved
thanks for the review, we made some nice changes to the package thanks to it
|
kamadorueda
changed the title
jonringer
reviewed
Jan 16, 2020
jonringer
approved these changes
Jan 16, 2020
| test/test_cloud_aws_cloudformation_rds.py \ | ||
| test/test_cloud_aws_cloudformation_s3.py \ | ||
| test/test_cloud_aws_cloudformation_secretsmanager.py \ | ||
| test/test_format_apk.py \ |
There was a problem hiding this comment.
you could use bash expansion to make this not so repetitive:
Suggested change
| test/test_format_apk.py \ | |
| test/test_format_{apk,file,jks,jwt,pdf,pkcs12,string}.py \ |
example:
$ echo test/test_format_{apk,file,jks,jwt,pdf,pkcs12,string}.py
test/test_format_apk.py test/test_format_file.py test/test_format_jks.py test/test_format_jwt.py test/test_format_pdf.py test/test_format_pkcs12.py test/test_format_string.py
|
@GrahamcOfBorg build fluidasserts python37Packages.mixpanel |
|
darwin failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's a pretty nice framework that you can use to build 'exploits' (scripts) to verify if previous vulnerabilities found in your systems are still open or closed, the complexity of such scripts is up to the developer, and that's what make it so powerful
It can be used as CLI tool too, to run the exploits, or with predefined (basic) tests like --http or --aws
We use it actively every day and therefore we would like to get it directly from nixpkgs
It's open source https://fluidattacks.com/asserts/
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)nix-linter
nix-review