Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cfn-flip: 1.1.0.post1 -> 1.2.2 #77788

Merged
merged 1 commit into from Feb 10, 2020
Merged

pythonPackages.cfn-flip: 1.1.0.post1 -> 1.2.2 #77788

merged 1 commit into from Feb 10, 2020

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jan 15, 2020 •
edited

Motivation for this change

keeping it updated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamadorueda
Copy link
Member Author 

nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
From https://github.com/NixOS/nixpkgs
   712bf54f1be..acadaa800b5  master     -> refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-4c14026ff474feca4b709b1def167ab8a1f3d2c3/nixpkgs acadaa800b566f6237d12428044662e9ec942097
Preparing worktree (detached HEAD acadaa800b5)
Updating files: 100% (20762/20762), done.
HEAD is now at acadaa800b5 chrome-token-signing: fix qt runtime error
$ nix-env -f /home/kamado/.cache/nix-review/rev-4c14026ff474feca4b709b1def167ab8a1f3d2c3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 4c14026ff474feca4b709b1def167ab8a1f3d2c3
Updating acadaa800b5..4c14026ff47
Fast-forward
 pkgs/development/python-modules/cfn-flip/default.nix | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)
$ nix-env -f /home/kamado/.cache/nix-review/rev-4c14026ff474feca4b709b1def167ab8a1f3d2c3/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-4c14026ff474feca4b709b1def167ab8a1f3d2c3/build.nix
[1 built, 0.0 MiB DL]
3 package were built:
python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

@ofborg ofborg bot requested a review from PsyanticY January 15, 2020 21:14
jonringer
jonringer approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM :)

pkgs/development/python-modules/cfn-flip/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented Jan 17, 2020 •
edited

need to fix-up your fluidasserts package:

  ERROR: Could not find a version that satisfies the requirement cfn-flip==1.1.0.post1 (from fluidasserts==20.1.23042) (from versions: none)
  ERROR: No matching distribution found for cfn-flip==1.1.0.post1 (from fluidasserts==20.1.23042)
cannot build derivation '/nix/store/5yfh21n5hiz8zgq5bavpzpyrg4jhrn92-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/5yfh21n5hiz8zgq5bavpzpyrg4jhrn92-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77788
1 package failed to build:
fluidasserts

3 package built:
python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

you can just append the commit to this PR

@kamadorueda
Copy link
Member Author

it's nice to see how things converge :)

I just deleted one line in the fluidasserts package

nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
^[[6;5~$ git worktree add /home/kamado/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1/nixpkgs 2628f20267d0c917772abc4c0a7c35788a740b31
Preparing worktree (detached HEAD 2628f20267d)
HEAD is now at 2628f20267d topgrade: fix, add darwin Foundation framework (#77700)
$ nix-env -f /home/kamado/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 52b3134101c7e0dce76bb945f2dfef6fb70b43f1
Updating 2628f20267d..52b3134101c
Fast-forward
 pkgs/development/python-modules/cfn-flip/default.nix     | 54 ++++++++++++++++++++++++++++++++++++++++++------------
 pkgs/development/python-modules/fluidasserts/default.nix |  1 -
 2 files changed, 42 insertions(+), 13 deletions(-)
$ nix-env -f /home/kamado/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1/build.nix
[2 built, 0.0 MiB DL]
4 package were built:
fluidasserts python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

$ nix-shell /home/kamado/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1/shell.nix
innovation

[nix-shell:~/.cache/nix-review/rev-52b3134101c7e0dce76bb945f2dfef6fb70b43f1]$ exit
$ git worktree prune

jonringer
jonringer approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[6 built, 36 copied (198.2 MiB), 30.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77788
4 package built:
fluidasserts python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

@jonringer
Copy link
Contributor

@GrahamcOfBorg build fluidasserts python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

@jonringer
Copy link
Contributor

darwin failure not directly related to package

@jonringer
Copy link
Contributor

@GrahamcOfBorg build fluidasserts python27Packages.cfn-flip python37Packages.cfn-flip python38Packages.cfn-flip

@FRidh FRidh merged commit 168b307 into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamadorueda @jonringer @FRidh