[WPT/common/security-features] Allow excluded_tests
based on expectation
value
#21185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
excluded_tests
excluded selectionsthat have the same values for the fields included in
selection_pattern
.However, as
selection_pattern
doesn't containexpectation
,expectation
can't be used inexcluded_tests
, blocking [1].After this CL:
excluded_tests
excluded selectionsthat have the same values for all the fields (except for
name
).For this purpose, this CL:
delivery_key
forexcluded_selection
, so thatselections and excluded selections have the same set of fields.
dump_test_parameters()
rather thanselection_pattern
for exclusion matching (
exclusion_dict
).This is a fix for cases like:
Previously: E excludes B but not A, so A is generated.
After this CL: B overrides A, then E excludes B.
As A is already overridden, no selections are generated.
This CL doesn't change generated results, because before [1]
there are no cases hitting these issues.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1991066
Bug: 906850
Change-Id: Ifa36167df710edd89d4e572346a3f1b928710119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991074
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731904}