Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT/common/security-features] Keep field order of spec.src.json #21184

Merged
merged 1 commit into from Jan 15, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2020

For easier debugging for [1]:
[1] will dump merged spec JSONs into files.
Keeping the field order makes taking diff easy.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1991066

Bug: 906850
Change-Id: Ibef14a818a52b4c58ee60272ecb2c1c653842a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991073
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731900}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

For easier debugging for [1]:
[1] will dump merged spec JSONs into files.
Keeping the field order makes taking diff easy.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1991066

Bug: 906850
Change-Id: Ibef14a818a52b4c58ee60272ecb2c1c653842a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991073
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731900}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants