Remove useBrowserInterfaceBroker from idl files and JS generate template #21187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1963910
branch
2 times, most recently
from
dea2342
to
08debd8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1963910
branch
from
08debd8
to
d79beb4
Compare
This CL removes the useBrowserInterfaceBroker parameter in mojo.idl, mojo_interface_interceptor.idl and JS generate template since all the interfaces in the following call sites are acquired through BrowserInterfaceBroker. Bug: 995556, 994843 Change-Id: I1b50496084eaec315539d75c40a39ceff8c8aa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963910 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738142}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1963910
branch
from
d79beb4
to
af1448f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes the useBrowserInterfaceBroker parameter in
mojo.idl, mojo_interface_interceptor.idl and JS generate template
since all the interfaces in the following call sites are acquired
through BrowserInterfaceBroker.
Bug: 995556, 994843
Change-Id: I1b50496084eaec315539d75c40a39ceff8c8aa43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963910
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738142}