Skip to content

networkmanager: 1.20.8 -> 1.22.4, modemmanager: 1.10.6 -> 1.12.2 #76205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2020
Merged

networkmanager: 1.20.8 -> 1.22.4, modemmanager: 1.10.6 -> 1.12.2 #76205

merged 3 commits into from
Jan 14, 2020
+36 −47

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.0/NEWS
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/blob/1.12.2/NEWS

Experimental features in NetworkManager are not enabled in this PR.

Things done

Built on master.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from Phreedom, domenkozar and obadz December 23, 2019 03:26
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 labels Dec 23, 2019
@jtojnar
Copy link
Member

jtojnar commented Dec 23, 2019

  • DHCP: switch "internal" DHCPv4 plugin from code based on systemd to use nettools' n-dhcp4 library.

Do we support that? Are nettools not needed?

I found https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/d3c7083f976f0e769d7f0b55c3024084e46667b1 but it does not make it very clear.

@worldofpeace
Copy link
Contributor Author

@jtojnar I think this is internal which is code in NetworkManager.
dhcp defaulted to internal since the update to 1.20. However I'm already seeing bugreports and fixes because of using this code https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/368/diffs.

@worldofpeace worldofpeace added the 2.status: work-in-progress This PR isn't done label Dec 23, 2019
@jtojnar
Copy link
Member

jtojnar commented Dec 23, 2019

Looks like the library is vendored so I retract my comment: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/tree/master/shared/n-dhcp4

@jtojnar jtojnar mentioned this pull request Dec 24, 2019
Closed
@worldofpeace worldofpeace force-pushed the network-manager/update branch from 167c99c to eb48d39 Compare January 6, 2020 15:17
@worldofpeace worldofpeace changed the title networkmanager: 1.20.8 -> 1.22.0, modemmanager: 1.10.6 -> 1.12.2 networkmanager: 1.20.8 -> 1.22.2, modemmanager: 1.10.6 -> 1.12.2 Jan 6, 2020
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jan 6, 2020 •
edited
Loading

I full confidence that 1.22.2 is probably more fab.

@worldofpeace worldofpeace removed the 2.status: work-in-progress This PR isn't done label Jan 8, 2020
@worldofpeace
Copy link
Contributor Author

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.4/NEWS, ooh 🤣
There's a fake hash in here, I should probably fix that in the next push.

@worldofpeace worldofpeace force-pushed the network-manager/update branch from eb48d39 to 4b33222 Compare January 13, 2020 18:07
@worldofpeace worldofpeace changed the title networkmanager: 1.20.8 -> 1.22.2, modemmanager: 1.10.6 -> 1.12.2 networkmanager: 1.20.8 -> 1.22.4, modemmanager: 1.10.6 -> 1.12.2 Jan 13, 2020
@worldofpeace
Copy link
Contributor Author

Built on d7627dd

/nix/store/qzr93yjmhnglkvbqfh6184bpiybpvics-network-manager-1.22.4
/nix/store/svcngl3lvnswjrb2cm01bbs1a6s1hyhw-modem-manager-1.12.2

@ofborg ofborg bot requested a review from callahad January 14, 2020 07:44
@worldofpeace
Copy link
Contributor Author

Ok, I've built everything and the only issue was with python-dbusmock which is fixed with the update.

@worldofpeace worldofpeace merged commit 470037f into NixOS:staging Jan 14, 2020
@worldofpeace worldofpeace deleted the network-manager/update branch January 14, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@dtzWill dtzWill

@Phreedom Phreedom

@domenkozar domenkozar

@obadz obadz

@FRidh FRidh

@jonringer jonringer

@callahad callahad

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @jonringer