Use the portal-host-including parent for console logging in AncestorThrottle. #21207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
…hrottle. This is already used for determining whether ancestors are permitted. It needs to be used also for figuring out which ancestor's console to log in. A web test that reaches this code using X-Frame-Options: DENY is included. Without the change to content/, this test fails with the same stack trace as in the linked bug. Bug: 1038256 Change-Id: Iad3623d82e0b2192eab626a2184d09d9d3e7be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002967 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732421}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002967
branch
from
c241162
to
dfc1dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already used for determining whether ancestors are permitted.
It needs to be used also for figuring out which ancestor's console to
log in.
A web test that reaches this code using X-Frame-Options: DENY is included.
Without the change to content/, this test fails with the same stack trace
as in the linked bug.
Bug: 1038256
Change-Id: Iad3623d82e0b2192eab626a2184d09d9d3e7be62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002967
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732421}