-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIDO2 luks support #77826
FIDO2 luks support #77826
Conversation
@1000101 To test it, follow the documentation to create your credentials and configure your system then run |
1dc81f1
to
471dedc
Compare
bba7abc
to
a3688a0
Compare
It works great with latest 5.4.x (5.4.11) kernel but when trying with stable 4.19.x (4.19.95) the prompt gets stuck waiting for additional entropy from the user (even with passwordless setup). |
Indeed, the problem with < 5.4 kernels is that when the system is booting and fido2luks is run during the initrd process, it can take several seconds to initialize because of limited entropy from the pool. This has been greatly fixed with random: try to actively add entropy rather than passively wait for it For now, I will just create a warning for end users to suggest using linuxPackages_latest with this option. |
f36e097
to
98edf5b
Compare
Let's wait until this change is released: shimunn/fido2luks@c4e0841 It adds |
@mmahut upstream just released 0.2.3, so we are good to go! \o/ https://github.com/shimunn/fido2luks/tags |
fc7549e
to
0b3bfa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! LGTM
FIDO2 luks support (cherry picked from commit 61dbbe4)
I've tried this but it doesn't work with any of the Yubikeys in the office. For yubikey 5 it prints:
|
I am not sure whether Yubikey 5 supports FIDO2 hmac-secret extension. |
Yes it does... I use FIDO2 support for it in many places including Microsoft Hello + Bitlocker (Which uses the same extensions as this tool) https://support.yubico.com/support/solutions/articles/15000014219-yubikey-5-series-technical-manual#FIDO2hx8dol including the required |
@arianvp are you sure your key has the required firmware version 5.2.3? |
Yes all our keys are updated to |
I've opened an upstream issue. I don't think we can do much here. shimunn/fido2luks#10 Hope we can fix it there (and backport it to 20.03) |
Perhaps we could instead base this module on https://github.com/mjec/fido2-hmac-secret ? It's actively used in Arch and based in the |
These are pretty strong words. Last commit to that repo was 19 days ago, while the module you are suggesting has the last commit in February. |
Sorry my wording could've been clearer and less strong. Thanks for calling me out on that. I wasn't talking about where Anyhow lets hope I can help debug with the Thanks for helping debugging |
Motivation for this change
This changes introduces the possibility of using FIDO2 compatible tokens with luks.
I'm using this change for several days but all testing is welcome.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)