Don't override background-images for atomic inlines in forced colors #21198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1998976
branch
from
8f8cecb
to
8e514df
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1998976
branch
4 times, most recently
from
09c8e68
to
7622da7
Compare
In a previous change, we had ignored background images for all inlines to prevent background images from being painted on top of the readability backplate in forced colors mode. https://chromium-review.googlesource.com/c/chromium/src/+/1757685 However, it turns out that atomic inlines paint their backgrounds before the backplate is painted. As such, we do not want to ignore background images for these inlines in forced colors mode. Bug: 970285 Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998976 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#733014}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1998976
branch
from
7622da7
to
e6bd644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous change, we had ignored background images for all inlines
to prevent background images from being painted on top of the
readability backplate in forced colors mode.
https://chromium-review.googlesource.com/c/chromium/src/+/1757685
However, it turns out that atomic inlines paint their backgrounds
before the backplate is painted. As such, we do not want to ignore
background images for these inlines in forced colors mode.
Bug: 970285
Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998976
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733014}