Add alignment.css ref to align-content-distribution tests #21174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 14, 2020
This CL: * adds a required reference to the alignment.css resource file, that provides alignment-related CSS classes used in several test cases. Adding this reference fixes the align-content-distribution tests. * changes the dimension of grids having 3 rows, .verticalLR and .stretchedGrid classes, and gives them a new value of 300px width and 400px height (by using the class .width300height400). This way each row width is now equal to 300px/3=100px, instead of the previous dimension of 400px/3=133,33...px. The 133,33...px dimension was, in fact, interpreted differently in different browsers, thus making some tests fail in WebKit and Firefox. * removes the -expected.txt files, related to align-content-distribution tests, that were generated when these tests were failing. Change-Id: I404dd188e8a2275042b4ace218c78a99e3248be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996303 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#731689}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1996303
branch
from
d43ba4f
to
c8ffbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL:
adds a required reference to the alignment.css resource file,
that provides alignment-related CSS classes used in several test cases.
Adding this reference fixes the align-content-distribution tests.
changes the dimension of grids having 3 rows, .verticalLR and
.stretchedGrid classes, and gives them a new value of 300px width and
400px height (by using the class .width300height400).
This way each row width is now equal to 300px/3=100px, instead of
the previous dimension of 400px/3=133,33...px. The 133,33...px dimension
was, in fact, interpreted differently in different browsers,
thus making some tests fail in WebKit and Firefox.
removes the -expected.txt files, related to align-content-distribution
tests, that were generated when these tests were failing.
Change-Id: I404dd188e8a2275042b4ace218c78a99e3248be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996303
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#731689}