Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nota: init at 1.0 #77702

Merged
merged 1 commit into from Jan 14, 2020
Merged

nota: init at 1.0 #77702

merged 1 commit into from Jan 14, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2020

Motivation for this change

Fixes #77590.

(see issue for more details)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
executable works fine

[4 built, 28 copied (1716.9 MiB), 139.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77702
1 package were built:
nota

@jonringer
Copy link
Contributor

looks like darwin times out trying to compile ghc. Merging

@jonringer jonringer merged commit afe9052 into NixOS:master Jan 14, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Jan 14, 2020

Thanks!

@dtzWill dtzWill deleted the feature/nota branch January 14, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: nota
2 participants
@dtzWill @jonringer