{openresty,nginxModules.brotli}: updates and improvements #77804
+77
−76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This updates the
ngx_brotli
module to the latest upstream version, and also rebases theopenresty
package on top of thenginx/generic.nix
infrastructure, simplifying things considerably and allowing the use of third-party modules with OpenResty.I haven't tested this extensively yet, but the build completes successfully for me and the OpenResty codebase is just a distribution of nginx, so I think it should be pretty low-risk.
nix build '(with (import ./. {}); openresty.override { modules = with nginxModules; [ brotli ]; })'
builds successfully with these changes.cc @thoughtpolice does this look reasonable to you?
@GrahamcOfBorg build nginx openresty
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)