Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teewords: 0.7.3.1 -> 0.7.4 #77794

Merged
merged 1 commit into from Jan 16, 2020
Merged

teewords: 0.7.3.1 -> 0.7.4 #77794

merged 1 commit into from Jan 16, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 15, 2020

Motivation for this change

upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from astsmtl January 15, 2020 23:40
@nh2
Copy link
Contributor

nh2 commented Jan 16, 2020

Commit message typo teewords - >teeworlds

@teto
Copy link
Member

teto commented Jan 16, 2020

I had a similar change I forgot to upstream. While you are at it, maybe you could run the missing hooks in build and configure phases: runHook preBuild / runHook postBuild.

@ajs124
Copy link
Member Author

ajs124 commented Jan 16, 2020

Done.

@teto teto merged commit 9120d20 into NixOS:master Jan 16, 2020
@ajs124 ajs124 deleted the upd/teeworlds branch January 16, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @nh2 @teto