Avoid infinite background tile scale #21209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002839
branch
2 times, most recently
from
ab54b56
to
e8758b3
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002839
branch
3 times, most recently
from
9b30da5
to
a6ca595
Compare
The issue happened when an SVG background image was painted with a very small background size rounded to zero, causing infinite tile scale and DCHECK failure in ClipRectOp. Bug: 1039762 Change-Id: Ia94ce2fd350b28696ef8068bd0e756bfc6d87a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002839 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732572}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002839
branch
from
a6ca595
to
6d89c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue happened when an SVG background image was painted with a very
small background size rounded to zero, causing infinite tile scale and
DCHECK failure in ClipRectOp.
Bug: 1039762
Change-Id: Ia94ce2fd350b28696ef8068bd0e756bfc6d87a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002839
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732572}