aview: new at 1.3.0rc1-debian4 #77711
Conversation
| ]; | ||
|
|
||
| meta = { | ||
| homepage = http://aa-project.sourceforge.net/; |
There was a problem hiding this comment.
| homepage = http://aa-project.sourceforge.net/; | |
| homepage = "http://aa-project.sourceforge.net/aview/"; |
| homepage = http://aa-project.sourceforge.net/; | ||
| description = "Aview is a high quality ascii-art image(pnm) browser and animation(fli/flc) player."; | ||
| license = stdenv.lib.licenses.gpl2; | ||
| platforms = [ "x86_64-linux" ]; |
There was a problem hiding this comment.
Are you sure it's not working / building on 32bit Linux ?
| pname = "aview"; | ||
| version = "1.3.0rc1-debian4"; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
Why do you choose your own fork for this? Upstream seems to point to sourceforge for source code download. If you'd like to advertise your own fork in NixOS, that's totally legit. Just name the package a little bit differently (maybe aview-deepfire) and change the homepage URL.
If your own fork in comparison with upstream is just a matter of a few bug fixes, it'd be a bit more pragmatic perhaps to use patches instead of a completely different fork.
There was a problem hiding this comment.
The project is dead and requires debian's patches to be applied -- which is the only thing I did: https://github.com/deepfire/aview/commits/master
You're right about patches though, @doronbehar, that'd be the better option.
|
Oh almost forgot: Please change the title of the issue and the commit message from |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
No response from OP. closing. |
Motivation for this change
Add
aview-- the ASCII art viewer accompanyingaalib.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)