Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageworsener: init at 1.3.3 #77710

Merged
merged 1 commit into from Feb 24, 2020
Merged

imageworsener: init at 1.3.3 #77710

merged 1 commit into from Feb 24, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 15, 2020

Motivation for this change

ImageWorsener is a high-quality command-line raster image scaling and processing tool, supporting a wide range of algorithms. It's packaged in Homebrew, Gentoo and FreeBSD.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
Copy link
Member Author

emilazy commented Jan 15, 2020

@GrahamcOfBorg build imageworsener

aanderse
aanderse approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I regret this was missed when you originally opened the PR. Please ping people on IRC, discord, github, etc... when you have a PR that slips through the cracks.

@aanderse aanderse merged commit 987d6c2 into NixOS:master Feb 24, 2020
@emilazy emilazy deleted the add-imageworsener branch February 24, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @aanderse