Skip to content

kind: 0.6.1 -> 0.7.0 #77789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

kind: 0.6.1 -> 0.7.0 #77789

merged 1 commit into from
Jan 17, 2020
+14 −14

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jan 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from rawkode, offlinehacker and ehmry January 15, 2020 21:48
marsam
marsam reviewed Jan 16, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update deps.nix or use buildGoModule

kind: 0.6.1 -> 0.7.0

Unverified

No user is associated with the committer email.
Learn about vigilant mode
30de00b
@kuznero
Copy link
Member Author

kuznero commented Jan 16, 2020

please update deps.nix or use buildGoModule

Done

@marsam marsam merged commit 8320821 into NixOS:master Jan 17, 2020
@marsam
Copy link
Contributor

marsam commented Jan 17, 2020

Thanks!

@kuznero kuznero deleted the kuznero/kind branch January 17, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@rawkode rawkode

@offlinehacker offlinehacker

@ehmry ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuznero @marsam