cupy: Move cudatoolkit to propagatedNativeBuildInputs to fix Thrust #77708
Conversation
The nvcc binary needs to be found in PATH at build time for Thrust support to be enabled. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 0
| @@ -18,8 +18,11 @@ buildPythonPackage rec { | |||
| mock | |||
| ]; | |||
|
|
|||
| propagatedBuildInputs = [ | |||
| propagatedNativeBuildInputs = [ | |||
There was a problem hiding this comment.
if it's just for nvcc to be on the path, this makes sense. Is there more that cudatoolkit provides?
My main concern is for cross compilation, in which it will get a binary of the wrong architecture.
However, seeing as linuxPackages.nvidia_x11 gets propagated as well, this expression probably isn't very cross compilation friendly
There was a problem hiding this comment.
cudatoolkit has both nvcc used at build time and libraries linked at runtime. I have no idea whether it might support cross compilation. But the question is entirely moot at this time, as we only package it for Linux x86-64.
There was a problem hiding this comment.
cudatoolkithas bothnvccused at build time and libraries linked at runtime.
If cudatoolkit doesn't contain any python libraries then it should not be in propagated. Now for libraries to link it should be in buildInputs. I believe, there is some strange thing that may be specific to python derivations, where binaries may not be visible unless they are also in nativeBuildInputs [1]. I never dug into this, but it seems like a bug in nixpkgs, so you might need to also have it in nativeBuildInputs as a workaround.
[1] #64047 (comment)
|
@andersk Could you please rebase. |
veprbl
added
the
2.status: merge conflict
ryantm
added
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Motivation for this change
The
nvccbinary needs to be found inPATHat build time for Thrust support to be enabled.Test case: check the
cupy.cuda.thrust_enabledboolean, or try to usecupy.sort, which doesn’t work without Thrust.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @hyphon81