-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symmetric bilinear forms on bivectors and the anticommutator form #2438
Symmetric bilinear forms on bivectors and the anticommutator form #2438
Conversation
// This operation is linear in |*this|. | ||
template<template<typename, typename> typename M = Multivector, | ||
typename = std::enable_if_t<base::is_same_template_v<M, Vector>>> | ||
SymmetricBilinearForm<Scalar, Frame, Bivector> Anticommutator() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this will require the dreaded template
at the call sites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, since we do not pass an explicit template parameter.
template<typename S, typename F> | ||
typename Multivector> | ||
bool operator==( | ||
SymmetricBilinearForm<Scalar, Frame, Multivector> const& left, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might fit on the previous line (several other places below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
SymmetricBilinearForm<Scalar, ToFrame> Identity<FromFrame, ToFrame>::operator()( | ||
SymmetricBilinearForm<Scalar, FromFrame> const& form) const { | ||
return SymmetricBilinearForm<Scalar, ToFrame>(form.coordinates()); | ||
template<typename Scalar, template<typename S, typename F> typename Multivector> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny that it fits on one line here but the declaration has 3 lines. I vastly prefer the 1-line version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
78 < 80.
retest this please |
Clean up after the merge of #2438
Together with
ClosedSystem
in #2435, this will replace most of the functionality ofInertiaTensor
.