Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsecret: 0.19.1 -> 0.20.0 #77709

Merged
merged 3 commits into from Jan 26, 2020
Merged

libsecret: 0.19.1 -> 0.20.0 #77709

merged 3 commits into from Jan 26, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2020

Motivation for this change

https://gitlab.gnome.org/GNOME/libsecret/-/tags/0.20.0

Patch to fix build from post-release commit :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alyssais
alyssais reviewed Jan 16, 2020
View reviewed changes
pkgs/development/libraries/libsecret/default.nix Outdated
@@ -1,15 +1,23 @@
{ stdenv, fetchurl, glib, pkgconfig, gettext, libxslt, python3, docbook_xsl, docbook_xml_dtd_42
{ stdenv, fetchurl, fetchpatch, glib, pkgconfig, gettext, libxslt, python3, docbook_xsl, docbook_xml_dtd_42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe getting a bit long? Rewrap?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is what is being suggested

nixpkgs/pkgs/desktops/pantheon/granite/default.nix

Line 1 in 1177bce

{ stdenv

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By whom? Not me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alyssais I meant that is what I believe what is being represented by "Maybe getting a bit long? Rewrap?". I also make a similar request to @dtzWill frequently with their PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I’m not for one line per argument at all! But a reasonable length limit, like 80, is good for readability.

@worldofpeace worldofpeace merged commit 1552bc6 into NixOS:master Jan 26, 2020
@dtzWill dtzWill deleted the update/libsecret-0.20.0 branch January 28, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @alyssais @worldofpeace