Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixed animation event tests should test content attributes too #21193

Open
stephenmcgruer opened this issue Jan 15, 2020 · 4 comments
Open

Comments

@stephenmcgruer
Copy link
Contributor

A set of tests for webkit-prefixed animation event handlers/listeners were added in #19099:

However as per #19099 (comment), these tests only test IDL attribute handlers and event listeners, but not content attribute handlers (i.e. <div onwebkitanimationend='foo()'></div>). We should expand the tests to cover content attribute handlers too. This will require some experimentation as to how content attribute handlers interact with IDL attribute handlers when both are set, as well as the easier task of adding a test for case sensitivity.

Note that for case-sensitivity, there is a already a positive-match test for the event casing in html/webappapis/scripting/events/event-handler-all-global-events.html ('the content attribute must execute when an event is dispatched'), but not a negative-match test making sure that an incorrect casing doesn't cause the content attribute to fire.

@stephenmcgruer
Copy link
Contributor Author

cc @bzbarsky as FYI

@bzbarsky
Copy link
Contributor

Note that to get the wrong casing for a content attribute you have to use setAttributeNS or XHTML, because setAttribute in HTML and the HTML parser both normalize attr names to all-lowercase...

@stephenmcgruer
Copy link
Contributor Author

Oh, I was thinking of casing of the event (i.e. dispatchEvent('webkitanimationend') should fail), but that's also a good point re casing of the attribute :)

@bzbarsky
Copy link
Contributor

Oh, yes. We should test both. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants