Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subfinder: 2.2.4 -> 2.3.0 #77748

Merged
merged 1 commit into from Jan 16, 2020
Merged

subfinder: 2.2.4 -> 2.3.0 #77748

merged 1 commit into from Jan 16, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 15, 2020 •
edited

Motivation for this change

https://github.com/projectdiscovery/subfinder/releases/tag/v2.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from fpletz and ehmry January 15, 2020 10:32
@Br1ght0ne
Copy link
Member Author

Thanks @ehmry! Can this be merged?

@ehmry
Copy link
Contributor

ehmry commented Jan 16, 2020

Sure, you are the maintainer.

@ehmry ehmry merged commit f7afe54 into NixOS:master Jan 16, 2020
@Br1ght0ne
Copy link
Member Author

you are the maintainer

But not yet a committer :)

@Br1ght0ne Br1ght0ne deleted the subfinder-2.3.0 branch January 16, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @ehmry