Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnused: 4.7 -> 4.8 #77766

Merged
merged 1 commit into from Jan 16, 2020
Merged

gnused: 4.7 -> 4.8 #77766

merged 1 commit into from Jan 16, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (centos with nix installed)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

This will need to go to staging, since gnused is part of our stdenv so an update will rebuild all the things. Bot will tag it accordingly shortly, presumably :).

Anyway, mostly wanted to link to the announcement/changelog:

https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00002.html

@matthiasbeyer
Copy link
Contributor Author

Rebased, added more information to the commit and pushed.

@matthiasbeyer matthiasbeyer changed the base branch from master to staging-next January 15, 2020 13:56
@ttuegel ttuegel removed their request for review January 16, 2020 15:37
@alyssais
Copy link
Member

Needs to go to staging, not staging-next. The README has a description of the staging process, but tl;dr PRs should always be to either master or staging, never staging-next.

@matthiasbeyer matthiasbeyer changed the base branch from staging-next to staging January 16, 2020 18:55
@matthiasbeyer
gnused: 4.7 -> 4.8
db99a2d 
Upstream announcement:
https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00002.html

For the lazy:

> * Noteworthy changes in release 4.8 (2020-01-14) [stable]
>
> ** Bug fixes
>
>   "sed -i" now creates temporary files with correct umask (limited to u=rwx).
>   Previously sed would incorrectly set umask on temporary files, resulting
>   in problems under certain fuse-like file systems.
>   [bug introduced in sed 4.2.1]
>
> ** Release
>
>   distribute gzip-compressed tarballs once again
>
> ** Improvements
>
>   a year's worth of gnulib development, including improved DFA performance

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@alyssais alyssais merged commit df4ec23 into NixOS:staging Jan 16, 2020
@matthiasbeyer matthiasbeyer deleted the update-sed branch January 17, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @dtzWill @alyssais