Replace short URL from #63103 with full URL. #77768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message is already helpfully verbose, so there's little reason to shorten the informational URL.
grahamc
reviewed
Jan 15, 2020
| @@ -406,7 +406,7 @@ rec { | |||
| In file ${def.file} | |||
| a list is being assigned to the option config.${option}. | |||
| This will soon be an error as type loaOf is deprecated. | |||
| See https://git.io/fj2zm for more information. | |||
| See https://github.com/NixOS/nixpkgs/pull/63103 for more information. | |||
There was a problem hiding this comment.
I thought about it, but decided instead to go with the idea that the original author intended there to be one full sentence per line. (The templated bits in the displayed message often greatly exceed the line length of the line I added.)
infinisil
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's polite to show a user where a URL is taking them before they follow it. Also, the message is already (helpfully) verbose, so there's not much benefit in using a shortener in the first place.
This change also makes the documentation consistent with existing practice when referring to GitHub pull requests in user-visible strings; see, for example:
nixpkgs/pkgs/top-level/all-packages.nix
Line 25036 in cd6ac55
nixpkgs/pkgs/development/libraries/jasper/default.nix
Line 47 in 273ec23
nixpkgs/pkgs/applications/networking/mailreaders/mailpile/default.nix
Line 49 in 0107ee8