Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yle-dl: add setuptools dependency #77811

Merged
merged 1 commit into from Jan 17, 2020
Merged

yle-dl: add setuptools dependency #77811

merged 1 commit into from Jan 17, 2020

Conversation

jluttine
Copy link
Member

Motivation for this change

yle-dl was failing with the following error:

ImportError: No module named pkg_resources

Adding setuptools to propagatedBuildInputs fixes this issue.

For a similar case, see: #73159.

cc: maintainer @dezgeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine
yle-dl: add setuptools dependency
080da6a 
yle-dl was failing with the following error:

  ImportError: No module named pkg_resources

Adding setuptools to propagatedBuildInputs fixes this issue.
@ofborg ofborg bot requested a review from dezgeg January 16, 2020 11:31
@worldofpeace
Copy link
Contributor

Here's the actual trace:

Traceback (most recent call last):
  File "/nix/store/48r2sjg5mv216aayb4mcs57gxrm96fdp-yle-dl-2.31/bin/.yle-dl-wrapped", line 6, in <module>
    from yledl.yledl import main
  File "/nix/store/48r2sjg5mv216aayb4mcs57gxrm96fdp-yle-dl-2.31/lib/python2.7/site-packages/yledl/__init__.py", line 2, in <module>
    from .yledl import download, StreamAction
  File "/nix/store/48r2sjg5mv216aayb4mcs57gxrm96fdp-yle-dl-2.31/lib/python2.7/site-packages/yledl/yledl.py", line 36, in <module>
    from .downloaders import downloader_factory, StreamFilters, IOContext, \
  File "/nix/store/48r2sjg5mv216aayb4mcs57gxrm96fdp-yle-dl-2.31/lib/python2.7/site-packages/yledl/downloaders.py", line 28, in <module>
    from pkg_resources import resource_filename
ImportError: No module named pkg_resources

@worldofpeace worldofpeace merged commit a1628d9 into NixOS:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @worldofpeace