geckodriver: 0.22.0 -> 0.26.0 #77802
Conversation
| src = let | ||
| # Source revisions are noted alongside the binary releases: | ||
| # https://github.com/mozilla/geckodriver/releases | ||
| rev = "e9783a644016aa9b317887076618425586730d73"; |
There was a problem hiding this comment.
I think it would be cleaner to just inline this.
There was a problem hiding this comment.
Somewhat strongly disagree, but can do.
There was a problem hiding this comment.
If you strongly disagree, feel free to leave it as you like. :)
There was a problem hiding this comment.
shrug I'm not invested either way :p
| url = "https://hg.mozilla.org/mozilla-central/archive/${rev}.zip/testing"; | ||
| sha256 = "0m86hqyq1jrr49jkc8mnlmx4bdq281hyxhcrrzacyv20nlqwvd8v"; | ||
| }).overrideAttrs (_: { | ||
| unpackCmd = "unzip $curSrc"; |
There was a problem hiding this comment.
There might be a better way to do this? This is here because unpack phases choose the command based on file extension and fetchzip as far as I know doesn't provide a way to change the filename.
There was a problem hiding this comment.
How about
unpackPhase = ''
unzip $src
'';
With a comment about why the normal unpackPhase doesn’t work?
There was a problem hiding this comment.
If you prefer it as you have it now that’s also fine.
There was a problem hiding this comment.
I'm not sure if that will work? fetchzip explicitly calls unpackFile as part of postFetch, but it makes sense to add a comment regarding why it's there.
arcnmx
force-pushed
the
geckodriver-0.26
branch
from
294ee60
to
480f351
Compare
Closes #76464 (see there for some discussion regarding what happened to the source)
Motivation for this change
0.22.0is well over a year old.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)