Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] signal-desktop: 1.29.3 -> 1.29.4 (backport) #77754

Merged
merged 1 commit into from
Jan 15, 2020
Merged

[19.09] signal-desktop: 1.29.3 -> 1.29.4 (backport) #77754

merged 1 commit into from
Jan 15, 2020
+2 −2

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 15, 2020

Changelog: https://github.com/signalapp/Signal-Desktop/releases/tag/v1.29.4
(cherry picked from commit 0e817da)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@primeos
signal-desktop: 1.29.3 -> 1.29.4
ad7e2d6 
Changelog: https://github.com/signalapp/Signal-Desktop/releases/tag/v1.29.4
(cherry picked from commit 0e817da)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).
@primeos primeos self-assigned this Jan 15, 2020
@primeos
Copy link
Member Author

primeos commented Jan 15, 2020

@GrahamcOfBorg test signal-desktop

@ofborg ofborg bot requested a review from ixmatus January 15, 2020 12:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 15, 2020
@primeos primeos merged commit ab2d845 into NixOS:release-19.09 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos