Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] signal-desktop: 1.29.3 -> 1.29.4 (backport) #77754

Merged
merged 1 commit into from Jan 15, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 15, 2020

Changelog: https://github.com/signalapp/Signal-Desktop/releases/tag/v1.29.4
(cherry picked from commit 0e817da)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Changelog: https://github.com/signalapp/Signal-Desktop/releases/tag/v1.29.4
(cherry picked from commit 0e817da)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).
@primeos primeos self-assigned this Jan 15, 2020
@primeos
Copy link
Member Author

primeos commented Jan 15, 2020

@GrahamcOfBorg test signal-desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant