Skip to content

Add myself as vim plugins codeowner #77806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

softinio
Copy link
Member

@softinio softinio commented Jan 16, 2020

Motivation for this change
  • I have been a vim user for over 20 years and am very passionate about supporting and keeping vim support in nixpkgs up to date
  • have been submitting PRs to keep plugins up to date and adding new ones not present
  • Have experienced delays in getting PRs reviewed so I feel we don't have enough reviewers with an interest in being responsible for the vim eco system so would like to volunteer to be responsible and help with PR reviews and merges of all things vim related to help progress this faster and take the workload off the existing reviewers. I can commit 1 hour per day for PR reviews and merging vim related.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@softinio softinio requested a review from edolstra as a code owner January 16, 2020 07:02
@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 16, 2020
@marsam marsam merged commit 0e4a7d9 into NixOS:master Jan 29, 2020
@marsam
Copy link
Contributor

marsam commented Jan 29, 2020

@softinio thank you for volunteering

@softinio
Copy link
Member Author

@marsam thank you

@softinio softinio deleted the update-codeowners branch January 29, 2020 16:54
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants